Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SRS initialization logic into SRS constructor #1054

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

litt3
Copy link
Contributor

@litt3 litt3 commented Dec 20, 2024

Changes

  • Add G2Trailing SRS data into SRS struct
    • Discussed with @bxue-l2, since these points are SRS, it makes sense to include them in the struct directly
    • This change enabled the SRS initialization simplifications
  • Extract SRS initialization from Prover and Verifier
    • The code in these two locations was nearly identical
    • This abstraction allows me to avoid an additional duplication of this logic, while implementing a further utility which requires SRS

@litt3 litt3 self-assigned this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant